fix quota reset reservation race

server/internal/tenant/app/generation_task_runtime.go

@@ -79,29 +79,34 @@ func HandleClaimedGenerationTaskFailure(
 	}
 
 	if task.QuotaReservationID > 0 {
-		balance, balanceErr := quotaRepo.GetCurrentBalance(cleanupCtx, task.TenantID, "article_generation")
-		if balanceErr != nil {
-			failureErr = errors.Join(failureErr, fmt.Errorf("load quota balance for refund: %w", balanceErr))
-		} else if task.OperatorID > 0 {
-			reason := "generation_refund"
-			referenceType := "generation_task"
-			taskReferenceID := task.ID
-			if _, err := quotaRepo.InsertQuotaLedger(cleanupCtx, repository.QuotaLedgerInput{
-				TenantID:      task.TenantID,
-				OperatorID:    task.OperatorID,
-				QuotaType:     "article_generation",
-				Delta:         1,
-				BalanceAfter:  balance + 1,
-				Reason:        &reason,
-				ReferenceType: &referenceType,
-				ReferenceID:   &taskReferenceID,
-			}); err != nil {
-				failureErr = errors.Join(failureErr, fmt.Errorf("insert generation refund ledger: %w", err))
-			}
+		var balance int
+		balanceErr := error(nil)
+		if task.OperatorID > 0 {
+			balance, balanceErr = quotaRepo.GetCurrentBalance(cleanupCtx, task.TenantID, "article_generation")
 		}
-
-		if err := quotaRepo.RefundReservation(cleanupCtx, task.QuotaReservationID, task.TenantID); err != nil {
+		refunded, err := quotaRepo.RefundPendingReservation(cleanupCtx, task.QuotaReservationID, task.TenantID)
+		if err != nil {
 			failureErr = errors.Join(failureErr, fmt.Errorf("refund generation reservation: %w", err))
+		} else if refunded {
+			if balanceErr != nil {
+				failureErr = errors.Join(failureErr, fmt.Errorf("load quota balance for refund: %w", balanceErr))
+			} else if task.OperatorID > 0 {
+				reason := "generation_refund"
+				referenceType := "generation_task"
+				taskReferenceID := task.ID
+				if _, err := quotaRepo.InsertQuotaLedger(cleanupCtx, repository.QuotaLedgerInput{
+					TenantID:      task.TenantID,
+					OperatorID:    task.OperatorID,
+					QuotaType:     "article_generation",
+					Delta:         1,
+					BalanceAfter:  balance + 1,
+					Reason:        &reason,
+					ReferenceType: &referenceType,
+					ReferenceID:   &taskReferenceID,
+				}); err != nil {
+					failureErr = errors.Join(failureErr, fmt.Errorf("insert generation refund ledger: %w", err))
+				}
+			}
 		}
 	}