fix quota reset reservation race

server/internal/tenant/app/template_service.go

@@ -626,28 +626,29 @@ func (s *TemplateService) failGeneration(ctx context.Context, job generationJob,
 	}
 
 	balance, balanceErr := quotaRepo.GetCurrentBalance(cleanupCtx, job.TenantID, "article_generation")
-	if balanceErr != nil {
-		cleanupErr = errors.Join(cleanupErr, fmt.Errorf("load quota balance for refund: %w", balanceErr))
-	} else {
-		reason := "generation_refund"
-		referenceType := "generation_task"
-		taskReferenceID := job.TaskID
-		if _, err := quotaRepo.InsertQuotaLedger(cleanupCtx, repository.QuotaLedgerInput{
-			TenantID:      job.TenantID,
-			OperatorID:    job.OperatorID,
-			QuotaType:     "article_generation",
-			Delta:         1,
-			BalanceAfter:  balance + 1,
-			Reason:        &reason,
-			ReferenceType: &referenceType,
-			ReferenceID:   &taskReferenceID,
-		}); err != nil {
-			cleanupErr = errors.Join(cleanupErr, fmt.Errorf("insert generation refund ledger: %w", err))
-		}
-	}
-
-	if err := quotaRepo.RefundReservation(cleanupCtx, job.ReservationID, job.TenantID); err != nil {
+	refunded, err := quotaRepo.RefundPendingReservation(cleanupCtx, job.ReservationID, job.TenantID)
+	if err != nil {
 		cleanupErr = errors.Join(cleanupErr, fmt.Errorf("refund generation reservation: %w", err))
+	} else if refunded {
+		if balanceErr != nil {
+			cleanupErr = errors.Join(cleanupErr, fmt.Errorf("load quota balance for refund: %w", balanceErr))
+		} else {
+			reason := "generation_refund"
+			referenceType := "generation_task"
+			taskReferenceID := job.TaskID
+			if _, err := quotaRepo.InsertQuotaLedger(cleanupCtx, repository.QuotaLedgerInput{
+				TenantID:      job.TenantID,
+				OperatorID:    job.OperatorID,
+				QuotaType:     "article_generation",
+				Delta:         1,
+				BalanceAfter:  balance + 1,
+				Reason:        &reason,
+				ReferenceType: &referenceType,
+				ReferenceID:   &taskReferenceID,
+			}); err != nil {
+				cleanupErr = errors.Join(cleanupErr, fmt.Errorf("insert generation refund ledger: %w", err))
+			}
+		}
 	}
 	invalidateArticleCaches(cleanupCtx, s.cache, job.TenantID, &job.ArticleID)
 	if cleanupErr != nil {