fix quota reset reservation race

server/internal/tenant/repository/generated/quota.sql.go

@@ -13,7 +13,7 @@ import (
 
 const confirmReservation = `-- name: ConfirmReservation :exec
 UPDATE quota_reservations SET status = 'confirmed', consumed_amount = reserved_amount, updated_at = NOW()
-WHERE id = $1 AND tenant_id = $2
+WHERE id = $1 AND tenant_id = $2 AND status = 'pending'
 `
 
 type ConfirmReservationParams struct {
@@ -114,7 +114,7 @@ func (q *Queries) InsertQuotaLedger(ctx context.Context, arg InsertQuotaLedgerPa
 
 const refundReservation = `-- name: RefundReservation :exec
 UPDATE quota_reservations SET status = 'refunded', refunded_amount = reserved_amount, updated_at = NOW()
-WHERE id = $1 AND tenant_id = $2
+WHERE id = $1 AND tenant_id = $2 AND status = 'pending'
 `
 
 type RefundReservationParams struct {

server/internal/tenant/repository/generated/quota_sql_test.go

@@ -0,0 +1,19 @@
+package generated
+
+import (
+	"strings"
+	"testing"
+)
+
+func TestQuotaReservationTransitionsOnlyUpdatePending(t *testing.T) {
+	for name, query := range map[string]string{
+		"confirm": confirmReservation,
+		"refund":  refundReservation,
+	} {
+		t.Run(name, func(t *testing.T) {
+			if !strings.Contains(query, "status = 'pending'") {
+				t.Fatalf("%s reservation query must only update pending reservations; query:\n%s", name, query)
+			}
+		})
+	}
+}