harden article generation reliability

server/internal/tenant/app/generation_task_runtime.go

@@ -80,11 +80,13 @@ func HandleClaimedGenerationTaskFailure(
 
 	if task.QuotaReservationID > 0 {
 		balance, balanceErr := quotaRepo.GetCurrentBalance(cleanupCtx, task.TenantID, "article_generation")
-		if balanceErr == nil && task.OperatorID > 0 {
+		if balanceErr != nil {
+			failureErr = errors.Join(failureErr, fmt.Errorf("load quota balance for refund: %w", balanceErr))
+		} else if task.OperatorID > 0 {
 			reason := "generation_refund"
 			referenceType := "generation_task"
 			taskReferenceID := task.ID
-			_, _ = quotaRepo.InsertQuotaLedger(cleanupCtx, repository.QuotaLedgerInput{
+			if _, err := quotaRepo.InsertQuotaLedger(cleanupCtx, repository.QuotaLedgerInput{
 				TenantID:      task.TenantID,
 				OperatorID:    task.OperatorID,
 				QuotaType:     "article_generation",
@@ -93,10 +95,14 @@ func HandleClaimedGenerationTaskFailure(
 				Reason:        &reason,
 				ReferenceType: &referenceType,
 				ReferenceID:   &taskReferenceID,
-			})
+			}); err != nil {
+				failureErr = errors.Join(failureErr, fmt.Errorf("insert generation refund ledger: %w", err))
+			}
 		}
 
-		_ = quotaRepo.RefundReservation(cleanupCtx, task.QuotaReservationID, task.TenantID)
+		if err := quotaRepo.RefundReservation(cleanupCtx, task.QuotaReservationID, task.TenantID); err != nil {
+			failureErr = errors.Join(failureErr, fmt.Errorf("refund generation reservation: %w", err))
+		}
 	}
 
 	if task.ArticleID > 0 {